[MPlayer-dev-eng] altivec patch 4/5: RGB/BGR confusion

Diego Biurrun diego at biurrun.de
Thu Feb 9 01:23:05 CET 2006


On Wed, Feb 08, 2006 at 05:07:25PM +0100, Diego Biurrun wrote:
> On Wed, Feb 08, 2006 at 12:41:54PM +0100, Michael Niedermayer wrote:
> > 
> > patch ok if colors are ok with rgb24/bgr24 on all -vo's which work on the
> > ppc developers machine
> 
> Hmmm, 
> 
>   mplayer -vo x11 -vf format=bgr24,scale movie.avi
>   mplayer -vo x11 -vf format=rgb24,scale movie.avi
> 
> both produce wrong colors while vo_xv is fine.  This problem is not
> caused by this patch, though, it was present before.  Disabling AltiVec
> does not make a difference.
> 
> I assume the patch is still OK to apply then?

I tested some more with vo_png, vo_jpeg, vo_pnm and vo_tga.  vo_tga and
rgb24 create a blue picture, but this occurs with and without the patch.
Everything else is fine.

I cannot find any obvious regressions, so the patch is applied.

Diego




More information about the MPlayer-dev-eng mailing list