[MPlayer-dev-eng] [PATCH 0/12] various enhancements and bugfixes for the ALSA driver (v2)

[Ivan Kalvachev]

2006/2/7, Clemens Ladisch <cl at cl.domainfactory-kunde.de>:
> The Wanderer wrote:
>
> > > Corey Hickey wrote:
> > >
> > >> You seem to have made diffs against version 1.0pre7try2.
> >
> > the patch appears to apply cleanly. The only other explanation
> > I can think of offhand is that for some reason he's doing CVS updates
> > in a directory named for the last official release, so that it's
> > really the CVS version - which seems crazy, but does fit the observed
> > facts.
>
> I misconfigured my patch management utility.  These patches are indeed
> against the CVS version.
>
> > However, he does appear to be ignoring rules 1 ("patch against the
> > CVS version"), 2 ("make unified diff patches from the root of the
> > source tree") and 8 ("send patches as attachments") from
> > DOCS/tech/patches.txt.
>
> Sorry, didn't know it was there (although I did find libao2.txt).
>
>
> Clemens

I'm not sure that there is single mplayer developer that would risk to
flood his house with cola if he commits all these patches.

The best solution would be if you are granted with CVS write access so
you can commit them all by yourself. The only requrement is to keep
maintaining alsa driver.

Do everybody agree? Do you agree?