[MPlayer-dev-eng] Patches for NUT

Oded Shimon ods15 at ods15.dyndns.org
Tue Feb 7 18:09:00 CET 2006


On Sun, Feb 05, 2006 at 07:37:19PM +0200, Oded Shimon wrote:
> On Sat, Feb 04, 2006 at 02:52:42PM -0500, Rich Felker wrote:
> > On Sat, Feb 04, 2006 at 10:49:15AM +0200, Oded Shimon wrote:
> > > > > > > remove 2^n header restriction, 03-header-repeat.patch .
> > > > > 
> > > > > ok
> > > > 
> > > > IMO the wording is slightly confusing and makes it sound like the
> > > > headers must be repeated at EACH 2^n position.
> > > 
> > > well, it says SHOULD, not MUST, I haven't got any better ideas.. We can 
> > > polish it later.
> > 
> > The issue isn't SHOULD/MUST, it's that your wording implied that
> > headers should appear at _each_ 2^n position.
> 
> OK, using your phrasing:
> Each set of repeated headers not at the beginning or end of the file should 
> be stored at the earliest possible position after 2^n for some integer 
> power n
> Note: this allows an implementation reading the nut file to locate backup 
> headers in O(log filesize) time as opposed to O(filesize)
> 
> Can I commit?

Forgot to mention, committed.

- ods15




More information about the MPlayer-dev-eng mailing list