[MPlayer-dev-eng] Patches for NUT

[Oded Shimon]

On Mon, Feb 06, 2006 at 03:39:23PM +0100, Michael Niedermayer wrote:
> Hi
> 
> On Sun, Feb 05, 2006 at 06:17:53PM -0500, Rich Felker wrote:
> [...]
> > > > > I also considered 16 bit checksum, as adler32 is kind of a waste on 10-20 
> > > > > bytes, but 16 bits is too weak. :/
> > > > 
> > > > How is using 32 bits to verify 80-160 bits overkill?
> > > 
> > > Because of adler's behavior... after testing, I found that about 8 bits are 
> > > almost always zero (15 byte message), so it's effectively a 27 bit checksum 
> > > taking up 32 bits... (max values are 12 bits 'a' and 15 bits 'b')
> > > 
> > > 24 bit adler is even weirder than adler16, so that's no good. Does anyone 
> > > have any other thoughts regarding this?
> > 
> > I see. Michael, can you help with this? I have no good knowledge about
> > effectiveness of checksums.
> 
> yep, wanted to comment on that anyway ...
> adler isnt the best checksum around, but its fast and simple
> the adler checksum is made of 2 parts s1 and s2
> 
> [...]

So, in conclusion.... ?? What should we do? Add adler32 for the syncpoint? 
Something else?

P.S. Committed header repetition. Syncpoint checksum and overly big pts are 
the only issues left I am aware of.

- ods15