[MPlayer-dev-eng] [PATCH] altivec fixes, part 1: alignment

[Michael Niedermayer]

Hi

On Mon, Feb 06, 2006 at 05:09:44PM +0100, Michael Niedermayer wrote:
> Hi
> 
> On Mon, Feb 06, 2006 at 01:27:02AM -0500, Alan Curry wrote:
> [...]
> > -  vYCoeffsBank = malloc (sizeof (vector signed short)*lumFilterSize*dstW);
> > -  vCCoeffsBank = malloc (sizeof (vector signed short)*chrFilterSize*dstW);
> > +  vYCoeffsBank = memalign (16, sizeof (vector signed short)*lumFilterSize*c->dstH);
> > +  vCCoeffsBank = memalign (16, sizeof (vector signed short)*chrFilterSize*c->dstH);
> 
> wrong, rejected

reason: it will segfault 3 lines later due to writing into unallocated memory

together with the 3rd patch it might be ok, but this is a cvs policy violation
patches should be split into self contained parts (1. alignment 2, 
dstW/dstH fix) not into 1. alignment+half of the fix which alone totally
breaks the code and 2. the other half of the fix!

[...]

-- 
Michael