[MPlayer-dev-eng] [PATCH 0/12] various enhancements and bugfixes for the ALSA driver (v2)

[The Wanderer]

Guillaume Poirier wrote:

> Hi,
> 
> Corey Hickey wrote:
> 
>> Clemens Ladisch wrote:
>> 
>>> This is the second version of the patch series to fix various
>>> bugs in and to remove several unnecessary complications from the
>>> ALSA driver.
>> 
>> Wow. That's a lot of patches. I don't have time right now, but I'll
>> be happy to test them later.
>> 
>> ...however...
>> 
>> You seem to have made diffs against version 1.0pre7try2. Version
>> 1.0pre7 is very old, and try2 is just a security fix. Most likely
>> your patches won't even apply to current CVS, which is all any of
>> us develop on and accept bugreports/patches for.
> 
> ... though I don't recall a heck of a lot of develloppement around
> Alsa since pre7, so it should be all right :-P

As it happens, there have been enough changes to libao2/ao_alsa.c (to
which his first patch would apply) that I would expect to at least see
patch report having to offset the patch by some number of lines;
however, the patch appears to apply cleanly. The only other explanation
I can think of offhand is that for some reason he's doing CVS updates in
a directory named for the last official release, so that it's really the
CVS version - which seems crazy, but does fit the observed facts.

However, he does appear to be ignoring rules 1 ("patch against the CVS
version"), 2 ("make unified diff patches from the root of the source
tree") and 8 ("send patches as attachments") from DOCS/tech/patches.txt.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.