[MPlayer-dev-eng] Re: [PATCH] demux_avi: instant A-V sync correction on seeking

[Corey Hickey]

Alban Bedel wrote:
>>>The attached patch makes demux_avi recognize the current specified delay
>>>and adjust the requisite stream position accordingly. On the first test
>>>case above, mplayer will behave the same initially, but seeking will
>>>instantly delay the video 10 seconds. Seeking after adjusting sync using
>>>the +/- keys will work just as well. Stream delays from dwStart will
>>>work well, too, once dwStart is supported.
>>
>>Hmm... no responses. If I don't hear any negative feedback in 24 hours,
>>I'll assume this patch isn't an atrocity and I will commit it.
> 
> 
> I must say i really don't like the direct import of audio_delay in the
> demuxer layer. imho it would be better to pass it via arguments or
> at worst via some control (called right before seek).

Ok. I had used it as an external variable because it already was in
mplayer.c. This patch changes it to an argument to demux_seek().

I'll apply this after 48 hours if I don't get any feedback at all. This
fixes the only objection so far, but it is the weekend.... Somebody say
"apply it now" if the patch looks good.

-Corey
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: demux_avi-fast-sync2.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060205/5daee40f/attachment.txt>