[MPlayer-dev-eng] [PATCH] various weirdness in vf_expand when expanded width > frame width

Jason Tackaberry tack at urandom.ca
Sun Dec 31 17:10:34 CET 2006


On Sat, 2006-12-30 at 21:45 -0500, Jason Tackaberry wrote:
> Looks like this was a symptom of the vo, not expand.  See the attached
> very trivial patch which resolves this for vo_xv.  It should have no
> performance impact for the common case; it blanks the full xvimage slice
> when the mpi slice is offset horizontally.

Disregard the previous patch, it was the wrong way to do it.  See
instead the attached patch, which takes the more correct approach of
blacking the xvimage at allocation.  (At least, YV12 images will be
blacked; YUY2 images will be the same as before.)

There is a bug however with vo_x11 when vf_expand expands horizontally,
because vo_x11's draw_slice ignores the x offset.  But who uses vo_x11
anyway. :)

The expand osd stuff still needs to be fixed though, but at least the
attach patch addresses our more immediate concern.

Thanks,
Jason.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xv-black-xvimage.patch
Type: text/x-patch
Size: 442 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061231/318c7035/attachment.bin>


More information about the MPlayer-dev-eng mailing list