[MPlayer-dev-eng] [PATCH] configure: enhancement for runtime cpu detection and --target support under x86

Diego Biurrun diego at biurrun.de
Sun Dec 24 13:54:55 CET 2006


On Sun, Dec 24, 2006 at 08:31:19PM +0800, Zuxy Meng wrote:
> 2006/12/24, Diego Biurrun <diego at biurrun.de>:
> >On Sun, Dec 24, 2006 at 01:21:19AM +0100, Diego Biurrun wrote:
> >> On Wed, Dec 13, 2006 at 07:41:24PM +0800, Zuxy Meng wrote:
> >> > 2006/12/13, Diego Biurrun <diego at biurrun.de>:
> >> > >
> >> > >For just one line, no.  If you put 'if' (or similar) around a large
> >> > >number of lines, yes.
> >> >
> >> > OK. Patch without any cosmetic change included.
> >>
> >> The problem is that the patch still mixes several different issues and
> >> is thus hard to review.  I've extracted some parts in modified form, but
> >> not yet committed all of it.  Please try to keep your patches as small
> >> as possible, i.e. one patch per issue.
> >
> >Extracted and committed some more stuff.  The rest is up to you, I'm
> >running out of time and don't have a machine to test this properly.
> >The stuff I committed should of course be bug-free(TM).
> 
> Thanks!

Just so that there is no misunderstanding: The rest of your patch also
looked mostly good, but it simply had to be split.  Please send in a new
patch with the rest of your changes now.

Diego



More information about the MPlayer-dev-eng mailing list