[MPlayer-dev-eng] [PATCH] make ao_oss use the subopt helper (was: Re: [MPlayer-DOCS] Re: CVS: main/DOCS/man/en mplayer.1, 1.1160, 1.1161)

[Diego Biurrun]

Digging through old mails ..

On Sun, Dec 18, 2005 at 12:25:38AM +0100, Tobias Diedrich wrote:
> Diego Biurrun wrote:
> > On Sun, Nov 27, 2005 at 07:22:35PM +0100, Tobias Diedrich wrote:
> > > I think it was more clear before the change.
> > > Most drivers use either the suboption parser or support only one
> > > parameter.  The syntax explanation suggests that the suboption order
> > > is not important.  Before it was made clear that oss is an exception
> > > in that the order _is_ important, but maybe thats just me. :-)
> > 
> > I understand what your problem is now.  I'd say it needs a more general
> > fix, though.
> > 
> > > I think it might be good to convert oss to use the suboptionparser
> > > (breaks compatibility)
> > 
> > Definitely.  Breaking compatibility should not be a problem since this
> > has only been in the CVS version so far.
> 
> How about the attached patch?

Here's a version that applies ..

Diego