[MPlayer-dev-eng] DirectFB configure fix

[Ville Syrjälä]

On Thu, Dec 21, 2006 at 08:21:45PM +0100, Benjamin Zores wrote:
> On Thu, 21 Dec 2006 20:36:20 +0200
> Ville Syrjälä <syrjala at sci.fi> wrote:
> 
> > On Thu, Dec 21, 2006 at 07:09:11PM +0100, Benjamin Zores wrote:
> > > Hi,
> > > 
> > > Attached patch adds new option to configure to specify directfb-config path
> > > (same way it's done for other *-config binaries).
> > > It allows using it to retrieve DirectFB version, but also cflags and libs which
> > > allows cross-compilation by removing hardcoded include paths.
> > > 
> > > Ok to apply ?
> > 
> > No.
> > 
> > <snip>
> > > +  if "$_directfbconfig" --version >>"$TMPLOG" 2>&1 ; then
> > > +    if cc_check `$_directfbconfig --cflags` `$_directfbconfig --libs` >>"$TMPLOG" 2>&1 ; then
> > > +      _directfbversion=`$_directfbconfig --version | sed 's/[^0-9]//g'`
> > > +       if test "$_directfbversion" -gt 0913 ; then
> > 
> > This will break the version check again. Use major/minor/micro and 
> > dfb_version() like the current code.
> 
> It it used later on (see the patch) to determine the #define value, used in vo sources.

You need to use it here too.

-- 
Ville Syrjälä
syrjala at sci.fi
http://www.sci.fi/~syrjala/