[MPlayer-dev-eng] DirectFB configure fix

Ville Syrjälä syrjala at sci.fi
Thu Dec 21 19:36:20 CET 2006


On Thu, Dec 21, 2006 at 07:09:11PM +0100, Benjamin Zores wrote:
> Hi,
> 
> Attached patch adds new option to configure to specify directfb-config path
> (same way it's done for other *-config binaries).
> It allows using it to retrieve DirectFB version, but also cflags and libs which
> allows cross-compilation by removing hardcoded include paths.
> 
> Ok to apply ?

No.

<snip>
> +  if "$_directfbconfig" --version >>"$TMPLOG" 2>&1 ; then
> +    if cc_check `$_directfbconfig --cflags` `$_directfbconfig --libs` >>"$TMPLOG" 2>&1 ; then
> +      _directfbversion=`$_directfbconfig --version | sed 's/[^0-9]//g'`
> +       if test "$_directfbversion" -gt 0913 ; then

This will break the version check again. Use major/minor/micro and 
dfb_version() like the current code.

-- 
Ville Syrjälä
syrjala at sci.fi
http://www.sci.fi/~syrjala/



More information about the MPlayer-dev-eng mailing list