[MPlayer-dev-eng] Re: [PATCH] Add '-dvd-speed', use SET_STREAMING command to quieten DVD drives

mail at kraymer.de mail at kraymer.de
Sun Dec 17 19:32:07 CET 2006


> mail at kraymer.de wrote:
>
>> Again, I'd appreciate it if each sentence in the man page began with
>> on a new line.
>
> Ok.


Thanks, I commited the man page part with a few modifications.


>> Also, the following lines:
>> > +#define MSGTR_DVDlimitFail "Failed.\n"
>>
>> > +#define MSGTR_DVDlimitOk "Ok.\n"
>>
>> are IMO too general because they don't say anything about the attempt
>> to limit device speed.
>
> Ok, I changed it to MSGTR_FailedDotLF and MSGTR_OkDotLF.
>
> Update patch attached.


Hm, that's not really what I had in mind :). I changed the help_mp-en.h
file to give a more elaborate success/failure message.I didn't apply your latest MSGTR change to the source files because Nico
committed your previous patch now. Probably it's ok as it is now.

Thanks,

Sebastian





More information about the MPlayer-dev-eng mailing list