[MPlayer-dev-eng] Re: [PATCH] Add '-dvd-speed', use SET_STREAMING command to quieten DVD drives

[mail at kraymer.de]

> Nico Sabbi wrote:
>
>> ok to commit. I wonder if passing the speed parameter as Nx1350 rather
>>  than in KB/s isn't preferrable, but I don't have a strong position on
>>  the subject
>
> Well, I didn't want to arbitrarily limit it to Nx1350.
> Anyway, I can't commit it myself, so someone else will have to do
> that. :)

Before the man page parts are committed it would be right to insert line
breaks after each sentence.In principle, I'm willing to commit (although I usually don't touch any
code parts in the tree). I noticed that the patch doesn't apply here, all
hunks fail although the patch appears to be created against a fairly
recent svn? Did anybody else try?
Btw, IMO using Nx1350 will be more user intuitive since the regular user
might not know that number from top of the head. Or could we use both,
like using Nx1350 if the parameter is less than 100 (or 1000)?

Sebastian