[MPlayer-dev-eng] Re: [PATCH] Add "-dvd-speed", use SET_STREAMING command to quieten DVD drives

Nico Sabbi nicola_sabbi at fastwebnet.it
Sun Dec 17 10:04:24 CET 2006


Tobias Diedrich wrote:
> Nico Sabbi wrote:
> 
> 
>>I have no objection, except for the name of the function that I don't 
>>like: dvd_set_speed() conveys a better description
> 
> 
> Ok, here's an updated version.
> Also adds german message translations and fixes the error case where
> the user doesn't have write permission.
> 

ok to commit. I wonder if passing the speed parameter as Nx1350 rather 
than in KB/s isn't preferrable, but I don't have a strong position on 
the subject

-- 
"Without a frontend, mplayer is useless" - someone in mplayer-users



More information about the MPlayer-dev-eng mailing list