[MPlayer-dev-eng] [PATCH] mga_vid scaler limits

[Ville Syrjälä]

On Sat, Dec 16, 2006 at 07:24:25PM +0200, Kalev Soikonen wrote:
> On Sat, Dec 16, 2006 at 05:00:05PM +0200, Ville Syrjälä wrote:
> ...
> > Disabling vertical filtering allows source widths up to 2048. Note that 
> > this only applies to G450/G550. G200 and G400 can't handle it.
> 
> So G200/G400 cannot handle the case (sw > 1024 && sw == dw && sh == dh)
> and both x/y filtering is off?

They simply can't handle sw > 1024. Doesn't matter if filtering is 
enabled or not.

> > > +	if(sw > 1023)
> > > +		card->regs.besctl &= ~(1<<11);
> > > +	if(sh > 1023)
> > > +		card->regs.besctl &= ~(1<<10);
> > 
> > Shouldn't these be 1024?
> 
> I tested with sw==1024: upscaling is ok, but when downscaling, there's
> a glitchy left edge (like 4 pixels wide?)

I don't remember seeing that with DirectFB (or maybe I just failed to 
notice it). Maybe there's a problem in mga_vid's scaling factor or 
coordinate calculation.

-- 
Ville Syrjälä
syrjala at sci.fi
http://www.sci.fi/~syrjala/