[MPlayer-dev-eng] [PATCH] fix mencoder compilation with lavf X11 demuxer

[Michael Niedermayer]

Hi

On Wed, Dec 13, 2006 at 08:10:13PM -0500, Rich Felker wrote:
> On Thu, Dec 14, 2006 at 12:55:59AM +0100, Dominik 'Rathann' Mierzejewski wrote:
> > On Thursday, 14 December 2006 at 00:51, Corey Hickey wrote:
> > > Hello,
> > > 
> > > Compilation of mencoder fails for me now; lavf compilation includes some 
> > >  X11 headers, but mencoder's compilation doesn't link with the 
> > > corresponding libraries.
> > > 
> > > The attached patch fixes the problem for me. I don't know if it's the 
> > > right fix, so I won't threaten to apply it, but it would be nice if 
> > > somebody took care of this (or told me to apply my patch).
> > 
> > Can x11grab be easily disabled? More specifically, I'm trying to avoid
> > unnecessary dependencies in mencoder for binary packages. MEncoder doesn't
> > depend on any X11 libs currently and I intend to keep it that way.
> 
> IMO this reveals a whole cascade of problems:
> 
> - there should be a way to disable protocols if there's not already

patch welcome ...


> - the protocols should ideally be a separate library/separate level of
>   abstraction from the muxers/demuxers

should be easy, pretty much just a few svn mv + Makefile/configure changes
if iam not missing anything (and patch welcome ...)


> - wtf? grabbing belongs in a grabber app, not an a/v format library

well grabbing always was part of libavformat, you complain a little late


> - libavformat looks more like libffmpegapp than libavformat
> 
> Any ideas if there's a desire to fix any of them, and if so, how to go
> about doing it?

what about changing the x11grab code to use dlopen() ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus