[MPlayer-dev-eng] [PATCH] configure: enhancement for runtime cpu detection and --target support under x86

[Diego Biurrun]

On Wed, Dec 13, 2006 at 03:51:03PM +0800, Zuxy Meng wrote:
> 
> 2006/12/13, Diego Biurrun <diego at biurrun.de>:
> >On Wed, Dec 13, 2006 at 09:58:38AM +0800, Zuxy Meng wrote:
> >> Well, I don't guess so. If u add a pair of brackets around some old
> >> statements in C you're expected to reindent those statements. Similar
> >> in this case.
> >
> >Time to read DOCS/tech/patches.txt and DOCS/tech/svn-howto.txt.  Such a
> >change should go ina separate patch.
> 
> Well let me elaborate: if the original code looks like
> 
> memcpy(dst, src, len);
> 
> and I wish to change it to
> 
> if (dst)
>    memcpy(dst, src, len);
> 
> Do I have to first do
> 
> +if (dst)
> memcpy(dst, src, len);
> 
> and then
> 
> if(dst)
> -memcpy(dst, src, len);
> +    memcpy(dst, src, len);
> 
> ???

For just one line, no.  If you put 'if' (or similar) around a large
number of lines, yes.

Diego