[MPlayer-dev-eng] [PATCH] fix theora detection and compile when missing pkgconfig

Diego Biurrun diego at biurrun.de
Wed Dec 13 08:44:03 CET 2006


On Wed, Dec 13, 2006 at 08:16:10AM +0100, Gianluigi Tiesi wrote:
> On system without pkgconfig (i.e. mingw ... or my mingw :P)
> theora is only tested while linking it using -ltheora
> but it needs also -logg
> 
> Review the patch and change if needed
> 
> diff -NuBr -x.svn -xhelp_mp.h -xlibdha -x'*.so' -x'*.log' -x'*.a' -x'*.exe' -x'*.o' -xconfigure.log -xconfig.mak -x.cvsignore -xconfig.h -xcodecs.conf.h -xversion.h -x.depend main/configure sherpya/configure

Why so complicated?  Never heard of Subversion?

> --- main/configure	2006-12-13 05:56:05.139723200 +0100
> +++ sherpya/configure	2006-12-13 07:54:59.268096000 +0100
> @@ -6861,7 +6861,7 @@
> -  if cc_check ; then 
> +  if cc_check $_inc_extra; then 

This is redundant and thus wrong.

Diego




More information about the MPlayer-dev-eng mailing list