[MPlayer-dev-eng] [PATCH] configure: enhancement for runtime cpu detection and --target support under x86

[Rich Felker]

On Tue, Dec 12, 2006 at 10:59:25PM +0800, Zuxy Meng wrote:
> >> -elif x86 || x86_64; then
> >> +elif x86 || x86_64 && [ "$_runtime_cpudetection" = no -a -z "$_target" 
> >] ; then
> >
> >And do not use -a, use two checks and combine them with && (many more
> >cases of that)
> 
> Hmm...[], ! and -a/-o are used elsewhere in the configure. Forgive me
> I really didn't have any idea which alternative provides better
> compatibility.

This is just a stylistic convention of MPlayer. IMO (and others'
opinions too) the syntaxt for test/[ (-a, -o, etc.) is highly
unintuitive to someone reading, while && and || are obvious.

Rich