[MPlayer-dev-eng] [PATCH] configure: enhancement for runtime cpu detection and --target support under x86

[Reimar Doeffinger]

Hello,

Build system is not my area, but some random comments:

On Mon, Dec 04, 2006 at 10:26:53PM +0800, Zuxy Meng wrote:
> +if [ "$_runtime_cpudetection" = yes ] ; then

This applies to many, many places in the patch. I think for
compatibility reasons you're supposed to use the 'test' command instead
of []

> +  if ! ( x86 || x86_64 || ppc ) ; then

and "not" instead of !, there are shells that do not support '!'

> -elif x86 || x86_64; then
> +elif x86 || x86_64 && [ "$_runtime_cpudetection" = no -a -z "$_target" ] ; then

And do not use -a, use two checks and combine them with && (many more
cases of that)

>  	;;
> -    6) iproc=686
> +      6) iproc=686

cosmetics (also in some more places)

Greetings,
Reimar Doeffinger