[MPlayer-dev-eng] [PATCH] Get rid of -D_GNU_SOURCE

Reimar Doeffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Fri Dec 8 10:15:30 CET 2006


Hello,
it seems to be unneeded, so this patch removes it. sdl-config once again
is again a prime example why it is not a good idea to trust such scripts that
create cflags/ldflags for you, given the amount of hacks we need
currently to use it, not using it might even be the less complex
approach...

Greetings,
Reimar D?ffinger
-------------- next part --------------
Index: libmpcodecs/Makefile
===================================================================
--- libmpcodecs/Makefile	(revision 21535)
+++ libmpcodecs/Makefile	(working copy)
@@ -157,7 +158,6 @@
           -I../libmpdemux \
           -I../stream \
           -I../loader \
-          -D_GNU_SOURCE \
 
 CFLAGS-$(CONFIG_LIBAVUTIL)    +=  -I../libavutil
 CFLAGS-$(CONFIG_LIBAVCODEC)   +=  -I../libavcodec
Index: libfaad2/Makefile
===================================================================
--- libfaad2/Makefile	(revision 21535)
+++ libfaad2/Makefile	(working copy)
@@ -42,8 +42,6 @@
           syntax.c \
           tns.c \
 
-CFLAGS  = -D_GNU_SOURCE
-
 # The FIXED_POINT implementation of FAAD2 improves performance
 # on some platforms, especially for SBR files.
 ifeq ($(FAAD_FIXED),yes)
Index: dvdread/Makefile
===================================================================
--- dvdread/Makefile	(revision 21535)
+++ dvdread/Makefile	(working copy)
@@ -11,7 +11,7 @@
 
 LIBNAME = libdvdread.a
 
-CFLAGS= -D__USE_UNIX98 -D_GNU_SOURCE -DSTDC_HEADERS \
+CFLAGS= -D__USE_UNIX98 -DSTDC_HEADERS \
 	-DHAVE_LIMITS_H -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
 
 ifeq ($(DVDCSS_INTERNAL),yes)
Index: libdvdcss/Makefile
===================================================================
--- libdvdcss/Makefile	(revision 21535)
+++ libdvdcss/Makefile	(working copy)
@@ -9,7 +9,7 @@
 
 LIBNAME = libdvdcss.a
 
-CFLAGS= -D__USE_UNIX98 -D_GNU_SOURCE \
+CFLAGS= -D__USE_UNIX98 \
 	-DHAVE_LIMITS_H -DHAVE_ERRNO_H -DHAVE_INTTYPES_H -DHAVE_UNISTD_H \
 	-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -DVERSION=\"1.2.9\"
 
Index: configure
===================================================================
--- configure	(revision 21535)
+++ configure	(working copy)
@@ -4596,7 +4596,7 @@
     _inc_extra="$_inc_extra `$_sdlconfig --cflags | sed s/-Dmain=SDL_main//`"
   else
     _libs_mplayer="$_libs_mplayer `$_sdlconfig --libs`"
-    _inc_extra="$_inc_extra `$_sdlconfig --cflags`"
+    _inc_extra="$_inc_extra `$_sdlconfig --cflags | sed s/-D_GNU_SOURCE=1//`"
   fi
   _vosrc="$_vosrc vo_sdl.c"
   _vomodules="sdl $_vomodules"
Index: libass/Makefile
===================================================================
--- libass/Makefile	(revision 21535)
+++ libass/Makefile	(working copy)
@@ -13,6 +13,6 @@
        ass_library.c \
        ass_font.c \
 
-CFLAGS  = -I../libmpcodecs -D_GNU_SOURCE
+CFLAGS  = -I../libmpcodecs
 
 include ../mpcommon.mak
Index: libaf/Makefile
===================================================================
--- libaf/Makefile	(revision 21535)
+++ libaf/Makefile	(working copy)
@@ -32,8 +32,6 @@
 SRCS-$(CONFIG_LIBAVCODEC)    += af_lavcresample.c
 SRCS-$(CONFIG_LIBAVCODEC_SO) += af_lavcresample.c
 
-CFLAGS  = -D_GNU_SOURCE
-
 CFLAGS-$(CONFIG_LIBAVUTIL)   += -I../libavutil
 CFLAGS-$(CONFIG_LIBAVCODEC)  += -I../libavcodec
 


More information about the MPlayer-dev-eng mailing list