[MPlayer-dev-eng] [PATCH] moved vorbis_* to ogg_stream

[Nico Sabbi]

Reimar Döffinger wrote:

>Hello,
>On Thu, Dec 07, 2006 at 01:05:05AM +0100, Nico Sabbi wrote:
>  
>
>>@@ -1623,8 +1628,10 @@
>>       if (ogg_d->text_langs[i]) free(ogg_d->text_langs[i]);
>>     free(ogg_d->text_langs);
>>   }
>>-  vorbis_info_clear(&ogg_d->vi);
>>-  vorbis_comment_clear(&ogg_d->vc);
>>+  if(os) {
>>+  vorbis_info_clear(&os->vi);
>>+  vorbis_comment_clear(&os->vc);
>>+  }
>>    
>>
>
>This only frees one of the potentially 50 or so that could have been
>allocated during audio stream switching.
>And I am also not sure it all this stuff will work for switching between
>vorbis streams with different sample rates, the code seems quite
>convoluted.
>
>Greetings,
>Reimar Döffinger
>  
>
yes, I have to iterate between all od->subs[] streams,
but fortunately no one implemented audio switching in demux_ogg ;)