[MPlayer-dev-eng] Sample translation lookup implementation

[Michael Niedermayer]

Hi

On Wed, Dec 06, 2006 at 06:21:35PM +0200, Uoti Urpala wrote:
> The patch implements a simple string-based translation lookup function.
> The purpose is mainly to prove wrong the "complexity" claims about
> string lookup and demonstrate that a simple implementation is enough to
> give functionality superior to catgets or other integer-based lookup
> schemes. The patch adds a simple translation lookup function and
> demonstrates the functionality by trying to translate mp_msg() messages.
> 
> The translation file format used is safe against problems caused by
> outdated translation files but not incorrect/malicious ones. It's not
> completely platform-independent (depends on values of PRI* macros) but
> should work enough to test on any platform.

some random comments (besides the already mentioned issues of using strings
as keys)
1. the file is not editable by normal text editors (very serious flaw IMO)
2. it mixes spaces and tabs for indention (yeah iam fully aware that this
   is mplayer-dev but still ...)
3. it mixes declaration and statements


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali