[MPlayer-dev-eng] [PATCH] configure fixes: x11 header dir always included, better CFLAGS for unknown compilers

Tue Dec 5 22:12:39 CET 2006

On Tuesday, 05 December 2006 at 18:33, Reimar Döffinger wrote:
> Hello,
> please say what you think.
> First part sets
> CFLAGS="-O2 $_march $_mcpu $_pipe"
> for non-intel, non-gnu compilers. None are supported so it might be
> pointless, but on the other hand it helps with trying some things out.

Just "-O2" is sufficient and doesn't break things. non-intel non-gnu compilers
probably don't support -march/-mcpu/-mtune switches.

> Maybe a detection for -ffast-math, -fomit-frame-pointer, and -O4 would
> be better, but also more complicated.

Hm. I'm tempted to try out ICC. Is there any non-intel non-gnu compiler
that can compile mplayer?

> The other part adds _inc_x11 only to _inc_extra if X11 is enabled. I
> intend to apply that port soon.

Sounds reasonable.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan