[MPlayer-dev-eng] [PATCH] Message translation

[Ötvös Attila]

hétfő 04 december 2006 19:08 dátummal Diego Biurrun ezt írta:
Hi Diego Biurrun!

Thank your answer.
> Proceed by idea, not by some arbitrary criterion like directory.
>
> Think of it this way: A patch should be as small as possible, but still
> make sense on its own. If I read one of your patches without the others
> I will not understand what you are trying to do, If I apply one without
> the others, the code will not compile anymore.
>
> Look at this translation patch, applying it is a lot of work.  I have to
>
> - save and unpack the tarball
> - copy some files into place
> - apply patch 1 through x
>
> What I want is a patch that I can directly apply with
>
>   patch --dry-run -p0 -i /path/to/patch
>
> If it takes me more than this step, then you are doing something wrong,
> i.e. your patch is split when it should have been one piece.
>
> So how can you ever split patches?  Try to separate changes that are
> logically different things.  For example if you rename a variable or if
> you add some comments or if you fix some unrelated bug, then all of
> these changes can (and should) go in patches of their own.
>
> If you send multiple patches, compress them individually, don't put them
> in a tarball.  Even better, send each patch in a mail of its own, it's
> much easier to track what was applied this way.
>
> I hope this helps you understand the process.  If not, keep asking.
I take it:
I will send 1 patch file at which contain all modifications.
If required then compress with gzip.

>
> A question: Do you have (much) previous experience with revision control
> systems?  How have you worked so far?
I somewhat CVS. 
I use rather private script.

If is it right split 2 patch:
1 - main translation system.
2 - apply translation all files [only MSGTR_?? replace with GT(MSGTR_??)]

Attila