[MPlayer-dev-eng] [PATCH] Make all subtitles availiable

[Guillaume POIRIER]

Hi,

On 12/4/06, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> Hello,
> On Mon, Dec 04, 2006 at 11:10:16PM +0100, Lehel Bernadt wrote:
> [...]
> > No, it cannot, but as i said in my previous mail, the numbers of
> > ID_SUBTITLE_ID are not sids. They are SPU IDs. In the example, -sid 1
> > = -slang sv = -vobsubid 3. -sid 7 does not exist, but -sid 3 maps to spu id 7
> > (also selectable with -vobsubid 7).
> > If you wish to display the sids there instead, it's possible to do it of
> > course. The reason why it displays the SPU IDs is because i needed some way
> > to check if the sid -> spu id mapping is working correctly.
>
> For all I can tell that is what ID_SUBTITLE_ID is good for. Considering
> that -identify is also for frontends there is not much point in making
> it display the SPU ID, what would a frontend want with that.
>
> > Or maybe the name should be changed to reflect that these are not the sid
> > numbers. Anyway, it's not a bug which affects the correct working of mplayer.
>
> It might affect the correct working of frontends.
> Nevertheless in this case I agree it is a different issue not directly
> related to this, so I don't have any further objections to the patch.
> Would be nice to see those ID_SUBTITLE_ID messages "fixed" (according to
> what I consider correct) anyway though.

Ok, very nice to hear; Lehel, fire up your mencoder patch, I'll test
it and hopefully commit both patches (as I said earlier, mencoder and
mplayer need to behave the same so that dumping vobsubs works in a
deterministic way).

Guillaume
-- 
An association of men who will not quarrel with one another is a thing
which has never yet existed, from the greatest confederacy of nations
down to a town meeting or a vestry.
 -- Thomas Jefferson
(when interviewed about MPlayer ML flamewars)
http://www.brainyquote.com/quotes/quotes/t/thomasjeff157207.html