[MPlayer-dev-eng] MSGTR messages for vid/aid in non-verbose output?

mail at kraymer.de mail at kraymer.de
Mon Dec 4 17:27:44 CET 2006


Andrew Savchenko wrote:
> On 2 Dec 2006 23:44, Diego Biurrun wrote:
>> On Tue, Nov 21, 2006 at 03:03:53PM +0300, Andrew Savchenko wrote:
>>> How about to add messages about found vid/aid numbers to
>>> standart (non-verbose) mplayer output? for examle:
>>> "video stream detected, vid %d"
>>> "audio stream detected, aid %d"
>>> regardless to the container format.
> ...
>>> I can make appropriate patch, if this will be allowed.
>> Such a patch would be very much welcome.  Especially for AVI
>> files we currently do not print any hint that it may contain
>> multiple audio tracks.  AFAIK all other demuxers do, though.
>
> I've made a quick overview in libmpdemux/* and it seems that not  only
> AVI demuxer won't print non-verbose messages about different  streams.
> The only demuxers providing such information are demux_ogg  and
> demux_mkv. Correct me if I'm wrong.
I tested your patch a bit and so far it appears to work fine (have no
multi-video or multi-audio avis though). What I noticed is thatinformation is redundant when playing dvds as track info is printed
similar to ogg/mkv already. I'm not sure about correctness of -vid for
dvds at all, does this equal to dvd-mpeg with several angles?
> So my suggestion is to add appropriate messages directly into
> demuxer.c, so they will be uniform despite of the demuxer type.  IMHO
> this will be usefull to user. OTOH this may make an overhead  of usefull
> information in the cases when format's dexuxer provides  this
> information also (such as demux_ogg and demux_mkv). Therefore  must be
> some check for demuxer type in order to realize necessity  of such
> message. I made this check to skip printing message in the  case of ogg
> or mkv demuxer.

See above, you might also want to skip in case of demuxing dvds.
I think it would also be nice to unify the output a bit. Matroska files
for example are prefixed with [mkv], later in the "chain" some decoder
output is prefixed by "VDec: .."; so maybe some kind of prefix ("Demux"?)
is applicable here too.
> BTW, I have noticed that there are a lot of translatable messages  with
> level below MSGL_V in libmpdemux/* (and in MPlayer code in  general)
> which are not present in master file help/help_mp-en.h  and are not
> translated. Is it ok to start extracting them into> help_mp-en.h?

I guess so. It might depend on how quick another translation system comes
up. But my feeling is that it's not immediate so if you like to, go ahead
imo.

Sebastian






More information about the MPlayer-dev-eng mailing list