[MPlayer-dev-eng] Re: [PATCH]Unicode support for ASF demuxer

[Zuxy Meng]

Hi,

2006/12/3, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
>
> Quite nice, thanks.
>
> >  #include "config.h"
> > +#include "common.h"
>
> We use "libavutil/common.h" in other places now.

OK

>
> I won't object if you want to keep it, but note that this is quite pointless
> IMO since it will crash anyway on strdup in demux_info_add, and
> printf/mp_msg is allowed (and on some systems will) crash, too.

If get_ucs2str() returns NULL, demux_info_add() won't get called and
no metadata is added.

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6