[MPlayer-dev-eng] Re: libcdio support "almost" there (Re: still more MacOS X build issues: "__attribute__" stuff)

[Diego Biurrun]

On Sat, Dec 02, 2006 at 07:13:18AM -0600, sci-fi at hush.ai wrote:
> On 2006-12-02 06:42:18 -0600, Reimar Döffinger 
> <Reimar.Doeffinger at stud.uni-karlsruhe.de> said:
> 
> >On Sat, Dec 02, 2006 at 05:28:16AM -0600, sci-fi at hush.ai wrote:
> >>Apparently someone thought Darwin can't build mplayer's own
> >>CDDB support for some reason, so these modules are skipped
> >>during make.  No matter, let's set _cddb=yes inside the libcdio
> >
> >It is me who "thought" this, and this is correct, since the read_toc
> >function does not work on OSX.
> >That disabling cddb breaks compilation is a bug though.
> 
> oh I definitely remember the read_toc problem,  ;)
> but with libcdio-0.78.2 and libcddb-1.3.0 this
> seems to be fixed now, clearly mplayer will see the
> CD when you give it the correct -cdrom-device that
> OSX chose to mount it upon.  Maybe we need to put
> some version checks in configure like other libs
> are treated, and warn when not at required levels?

Patches welcome.

Diego