[MPlayer-dev-eng] Re: [PATCH] Make all subtitles availiable

[Lehel Bernadt]

On Saturday 02 December 2006 11:27, Guillaume POIRIER wrote:
> On 12/1/06, Sturle Sunde <sturles at ifi.uio.no> wrote:
> > Lehel Bernadt <lehel at pmc-services.hu> writes:
> > > I have a more simple (and correct) patch for this, which i posted to
> > > the list twice already, but it seems like the dvd stuff is
> > > maintained by nobody, so no one was willing to apply it until now.
> > > The patch to today's svn is attached, please see if it works for
> > > you.
> >
> > I have reverted my own patch and tested yours after a svn update.  It
> > works fine.
>
> Did you test with the change suggested by Nico?
>
> Which is:
>
>  +  return d->subtitles[d->nr_of_subtitles-1].id;
>
> instead of
>
> +  return d->subtitles[d->nr_of_subtitles].id;
>
> in Lehel Bernadt's patch

That was not in my patch, it was in Sturle's :)

And this change wouldn't save it anyway, because here in dvd_number_of_subs() 
what should be returned is the number of subtitles, not the stream id.
My concept works the other way, it leaves the logical subtitle numbers as they 
are, and only switches to the real id in the mplayer.c main cycle.

Lehel