[MPlayer-dev-eng] [PATCH] demux_ogg.c broken bitrate detection on some files fixed
Andrew Savchenko
Bircoph at list.ru
Thu Aug 31 06:23:53 CEST 2006
Greetings!
It is bugfix for problem, described earlier in
mplayer-users at mplayerhq.hu as "BUG: invalid bitrate information for ogg
files and mkv video streams".
It was the problem in demux_ogg.c: it uses its own mechanism to
retrieve bitrate info into fixup_vorbis_wf(), but NOT standart function
vorbis_synthesis_headerin(). Moreover, this function is used in the
demux_ogg.c in demux_ogg_add_packet(), so I can't see any reason to
discard vorbis_synthesis_headerin() call into fixup_vorbis_wf().
Seems old bitrate info mechanism fails in rare cases, but
vorbis_synthesis_headerin() as replacement works fine for all files I
tested.
If you want, I can upload "problem" file to ftp for your testing.
Any opinions to apply?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-demux_ogg.c.patch
Type: text/x-diff
Size: 1462 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060831/c17a3215/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060831/c17a3215/attachment.pgp>
More information about the MPlayer-dev-eng
mailing list