[MPlayer-dev-eng] [PATCH] audioscrobbler support

[Guillaume Poirier]

Hi,

VMiklos wrote:
> On Sun, Aug 20, 2006 at 09:16:12PM +0200, Guillaume POIRIER <poirierg at gmail.com> wrote:
> 
>>>http://frugalware.org/~vmiklos/patches/mplayer-svn-audioscrobbler.diff
>>>
>>>basically it's not my work, i took the code from:
>>>
>>>http://www.last.fm/group/Mplayer/forum/17668/_/77244
>>>
>>>i've just made a patch against svn
>>>
>>>questions: could such a patch be ever merged? if yes, probably it should
>>>not be enabled by default. would a commandline switch be good?
>>
>>Is it necessary to add some new code to mplayer.c? Please be sure
>>before doing so.
>>What is this patch supposed to do? What advantage does it bring?
> 
> 
> it passes metadata of each played media to the lastfmsubmit daemon which
> will track them on last.fm. last.fm is a free service that tracks your
> musical taste, finds similar users, and provides musical recommendations
> and free personalised radio.
> 
> probably it should not be enabled by default, but i'm not sure what
> would be the good approach to enable it. a commandline option would do
> it?

yep. I personnaly have no use for this kind of functionnality in
MPlayer, and in fact, I'd live better without it at all.

One may not want one's tastes to be publicly available.

> also, maybe it would be possible not to do it in mplayer.c, but then i'm
> not sure what would be a better place

don't know.

Guillaume