[MPlayer-dev-eng] [PATCH] Crash in vf_spp.c and other things

[Gianluigi Tiesi]

final tests/results

aclib fast_memcpy crashes only on mingw, I need to investigate
and/or compare assembly linux vs mingw

fdct function is used in some files even in block not if-defed with
CONFIG_ENCODERS, there a list of files/info,
they are most incongruences / possible crashes if the function is called
but not assigned.

./libmpcodecs/vf_spp.c
line 412: p->dsp.fdct(block);
this block is compiled without CONFIG_ENCODERS
without CONFIG_ENCODERS this wouln't work at least it needs an fdct
function, it's a postprocessing filter.

./libavcodec/mpegvideo.c
line 6184: s->dsp.fdct(d1);
this is ok, the block is inside a CONFIG_ENCODERS ifdef

./libavcodec/asv1.c
line 375: a->dsp.fdct(block[i]);
line 381: a->dsp.fdct(block[i]);
this block is also compiled without CONFIG_ENCODERS
maybe not a problem since I think is never reached
without CONFIG_ENCODERS, but it becomes only blob
if encoders are disabled, encoding stuff should be ifdef-ed
where possible, right now only codec registration is ripped out.

./libavcodec/dsputil_xxx.c
dsputil_init assigns fdct functions only if defined CONFIG_ENCODERS

so I don't like to have defined CONFIG_ENCODERS also with
--disable-mplayer, I sent a lot of patches to make it works
other stuff also fixed by other and finally mplayer can compile without
encoders. Porting on embedded devices would be more suitable having
the ability to rip off unnedeed code.

if fdct assignment (function are anyway always included)
is not suitable outside CONFIG_ENCODERS, at least add a CONFIG_DCT
or something and fix vf_spp.c and asv1.c (I may miss other files I made
a simple grep over fdct( string) with ifdefs.

Regards

-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/