[MPlayer-dev-eng] [PATCH] further dvr-ms playback improvements

[Uoti Urpala]

On Fri, 2006-08-25 at 22:32 +0200, Nico Sabbi wrote:
> I mean that the duration reported is always 20 seconds, with or without 
> -correct-pts

So do you think that is incorrect? Since playing it does now take 20
seconds, if you believe it's accelerated overall then the duration has
to be wrong too.

> >But your patch set sh_video values in vd_ffmpeg. What reason is there
> >for that if the demuxer produces correct timestamps?

> in my patch I removed the assignment sh_video->pts=1000.0 from demux_asf.c
> because I consider absolutely random and arbitrary,

You mean fps=1000, not pts. Apparently several demuxers use that to
indicate that the video is VFR and does not have a constant frame rate.
It's interpreted by video.c; if fps is set to some other value then that
is used as frame duration ignoring timestamps, fps=1000 means packet
timestamps are used (the code depends on demuxer type, does affect
DEMUXER_TYPE_ASF). With -correct-pts that video.c code is not used at
all and the fps value is mostly ignored, only packet timestamps are used
always.

> but mplayer from svn doesn't even init when sh_video->pts == 0,

That means the value wasn't inited at all.

> thus I had to patch one of the decoders to assign the video framerate

Why? What was the point? Why did you want to remove the fps=1000
assignment? Sure that is an ugly way to handle it but does it have
anything to do with the problems with that file? Do you believe that the
decoder has more accurate timestamp information which cannot be obtained
in the demuxer (which you denied earlier)?