[MPlayer-dev-eng] [PATCH] libass support in vf_vo

[Evgeniy Stepanov]

On Friday 25 August 2006 21:41, Reimar Döffinger wrote:
> > +    case VFCTRL_DRAW_EOSD:
> > +    {
> > +        ass_image_t* images = 0;
> > +	double pts = vf->priv->vf_vo_data->pts;
>
> Looks like a tab slipped in here.

Yeah. This way it is in consistency with the style of vf_vo.c: half of the 
lines use tabs, another half - spaces. :)

Any well-formatted code looks out of context here. Why don't we reindent the 
whole file ?

> > +static void uninit(struct vf_instance_s* vf)
> > +{
> > +    if (vf->priv->ass_priv)
> > +        ass_done(vf->priv->ass_priv);
> > +}
>
> I think you should check for vf->priv != NULL and also free vf->priv.

Sure.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_vo.patch
Type: text/x-diff
Size: 4487 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060825/6412b524/attachment.patch>