[MPlayer-dev-eng] [PATCH] further dvr-ms playback improvements

Nico Sabbi nicola_sabbi at fastwebnet.it
Fri Aug 25 01:14:38 CEST 2006


John Donaghy wrote:

> Here's a patch to make playback of dvr-ms file works better. It
> resolves the following issues:
>
> - the picture can be jerky though you have to look carefully at the
> sample on mplayerhq.com to see the problem. I've noticed it more on
> some of my tv show recordings when watching them on a TV rather than a
> monitor.
>
> - the framesize is wrong and this is a real problem when playing HD 
> content
>
> The fix works by obtaining the framerate, bitrate and picture size
> from the codec and it borrows heavily from techniques used be the
> ffmpeg asf demuxer. I copied the code to parse an mpeg frame header
> from ffmpeg. I had wanted to call video_read_properties() when opening
> the stream after filling the buffer but too many things would have
> needed to be changed to make that work. I think this is the least
> intrusive way of doing it.
>
> I had to include asf.h in video.c becasue I cant see another way of
> doing what I did there but I'm open to suggestions.
>
> John
>
>------------------------------------------------------------------------
>

rejected: this code doesn't belong to demuxer that should - guess what? 
- *only demux*.
Why should the demuxer set fps, framesize and bitrate? these settings 
belong to the decoder.
If you post a sample I'll try to help you this week-end




More information about the MPlayer-dev-eng mailing list