[MPlayer-dev-eng] [RFC] Removing all trailing whitespace

Ivo ivop at euronet.nl
Mon Aug 21 11:50:36 CEST 2006


On Monday 21 August 2006 11:30, Diego Biurrun wrote:
> On Mon, Aug 21, 2006 at 12:56:04AM +0200, Diego Biurrun wrote:
> > On Sun, Aug 20, 2006 at 11:59:48PM +0200, Michael Niedermayer wrote:
> > >
> > > iam in favor of it, though i suggest you do a quick svn di before ...
> >
> > I'm also in favor, though I'd suggest doublechecking with
> >
> >   svn diff --diff-cmd diff --extensions -b
> >
> > to make sure no non-whitespace changes crept in.
>
> Also, some lines in the man pages end on "\ " on purpose, this should be
> changed to be enclosed by doublequotes first.

Yes. I was afraid it wouldn't work flawlessly on documents, so that's why I 
suggested running it on *.[ch] first.

As for testing/diffing, if we agree on running this is a good thing, I will 
do the following:

* run find-exec-sed

* run your svn diff --diff-cmd ...

* run svn diff and browse for "funny" lines. I don't expect any to pop up, 
but better be safe than sorry.

* build mplayer with and without the change and md5sum the binary

I already did that once as a test and the binaries were identical, but I'll 
do it again if we decide on proceeding with this.

Also, as this is discussed on mplayer-dev-eng, I don't plan on running this 
on libav*. I think it's best to discuss that in a separate thread on 
ffmpeg-devel.

--Ivo



More information about the MPlayer-dev-eng mailing list