[MPlayer-dev-eng] [PATCH] drag and drop handling - this fix has been ignored

[laurent wozniak]

Hello,

This fix has been ignored.
Is there any problem with it, please ?
Or it just get lost in the noise ?

I've included it again as an attached file this time.

Cheers,
Laurent

laurent wozniak wrote:
> Hello,
>
> The file drag and drop has not been working for a while, here is a 
> very simple patch to correct this.
>
> Patch is included inline at the end.
>
> The symptom has already been described in another list:
>
>> From: Stephen Watson <stephen <at> kerofin.demon.co.uk>
>> Subject: Two bugs in drag and drop to mplayer
>> Newsgroups: gmane.comp.video.mplayer.user
>> Date: 2005-11-30 18:31:43 GMT (35 weeks, 1 day and 12 minutes ago)
>>
>> I've found 2 bugs in mplayer's drag and drop handling.
>>
>> The first bug is when mplayer processes the passed urls it counts how 
>> many
>> valid ones it finds, then subtracts 1 for no reason. The result is 
>> that if
>> you drag N files, it plays N-1.  If you drag 1 it plays none.
>
> There is some history around this bug:
> - 2004-03-20 12:46 AM: First, it has been introduced as a "fix" !
> "fix: adds a file to many when d n' d."
> Well, there were no problem. Now there is one: drag and drop is not 
> working anymore since one file is missing.
> I think this fix might have tried to compensate a bug somewhere else. 
> But the original algorithm looks correct.
> - 2004-03-25 10:49 PM: Commit on subversion: "wsxdnd.c" rev 12069
> - 2004-09-21 03:37 PM: Problem reported in user list
> - 2005-11-30 06:31 PM: Patch posted in wrong list (user list)
>
> I've tested the bug and the patch on: Linux / GNome / Fedora core 4
>
> Cheers,
> Laurent
>
>
> Index: /home/contrib/mplayer/mplayer/Gui/wm/wsxdnd.c
> ===================================================================
> --- /home/contrib/mplayer/mplayer/Gui/wm/wsxdnd.c    (revision 19294)
> +++ /home/contrib/mplayer/mplayer/Gui/wm/wsxdnd.c    (working copy)
> @@ -124,7 +124,7 @@
>           /* Handle the files */
>       if(wnd->DandDHandler){
> -    wnd->DandDHandler(num-1,files);
> +    wnd->DandDHandler(num,files);
>       }
>     }
>
> ====
>
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

-------------- next part --------------
A non-text attachment was scrubbed...
Name: dnd.diff
Type: text/x-patch
Size: 330 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060819/008e7866/attachment.bin>