[MPlayer-dev-eng] [PATCH] fix closed caption display for TiVo/tystreams

[Doug Swarin]

Nico Sabbi wrote:
> Doug Swarin wrote:
> > Thanks very much to the people who pointed out the rules to patches
> > for me. I apologize for submitting incorrectly before. This patch has
> > been updated to apply against the latest SVN trunk and follows all the
> > rules from http://www.mplayerhq.hu/DOCS/tech/patches.txt.
> >
> > This patch changes the '-subcc' option to take an integer argument,
> > where '-subcc 1' displays the normal Closed Caption data, and '-subcc
> > 2' will display the XDS data. '-subcc 3' will display both.
> >
> > It fixes the tystream code to properly display Closed Caption
> > subtitles (before, only the XDS data would be displayed, and that
> > erratically). Also, it corrects roll-up captions to not immediately
> > overwrite themselves.
> >
> > All documentation has been updated (although I do not speak any
> > language other than English, so I was unable to give directions for
> > anything but -subcc 1 in the other documentation).
> >
> > Thanks,
> > Doug
> >
> >------------------------------------------------------------------------
> >
>
> it's full of cosmetics; repost the patch without them, please

I'm very sorry, but I see no cosmetic changes in the patch except one
removal of a trailing space from a blank line which crept in around
line 287 of the patch in ty_drawchar(). Could you please point out
what other cosmetic changes you refer to? All other changes should be
completely functional.

Many of the lines are changing ty_OSD1 to ty_OSD2, which may look
almost identical as if it were a cosmetic change.

I can repost it without that one error if you wish.

Thanks,
Doug