[MPlayer-dev-eng] [PATCH] config.h from MPlayer clashes with config.h from x264

[Vladislav Naumov]

On 8/15/06, Jan Knutar <jknutar at nic.fi> wrote:
> On Monday 14 August 2006 12:26, Vladislav Naumov wrote:
>
> > Patch I've attached puts $(OPTFLAGS) after '-I..'.
>
> The patch doesn't modify libavformat/ and friends, so the compile
Yuck!
Missed those externals completely.
Here's a patch for it (previous patch not included, apply both).

> still fails, and it might be a bit troublesome to get these kind of changes
> into ffmpeg just to fix MPlayer...
Maybe.
Anyway, either we push those changes everywhere, sorting include dirs
properly, or we make every .h completely distinguishable
(mplayer_config.h, x264_config.h, etc).

Renaming files seems like a "cleaner" solution to me, but needs more
work (71 trivial change in mplayer tree, grep says).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: config_h_clash_external.diff
Type: text/x-patch
Size: 1866 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060815/a17afca1/attachment.bin>