[MPlayer-dev-eng] [PATCH] -fPIC support for libswscale

[Diego Biurrun]

On Mon, Aug 14, 2006 at 11:22:02AM -0400, Jason Tackaberry wrote:
> On Mon, 2006-08-14 at 11:16 -0400, Jason Tackaberry wrote:
> > Compiled and tested with gcc 2.95.3 (x86), gcc 3.2.3 (x86), gcc 3.4.2
> > (x86_64), and gcc 4.0.2 (x86).  In each case, libswscale was compiled
> > with -fPIC and -fno-PIC.  Build successful in all 8 cases.
> > 
> > Test involved playing:
> > 
> >    mplayer testfile.avi -vf scale=320:200 -sws 9 -vo png -frames 20
> > 
> > In all 8 cases, the resulting md5sum of the 20 png files was identical.
> > (I also repeated with -sws 2, md5sums also identical.)
> 
> I forgot to mention, from my original email, I also tested the following
> code paths (each separately with MMX, MMX2, 3DNOW, and C):
> 
>         Scaling and/or colorspace conversion (non-special converters):
>               * YV12->BGR32 BICUBIC downscale
>               * YV12->BGR24 BICUBIC downscale
>               * RGB24->YUY2 BILINEAR upscale
>               * BGR24->YUY2 BILINEAR upscale
>               * BGR24->YUY2 FAST BILINEAR upscale
>               * BGR32->RGB32 FAST BILINEAR downscale
>               * Y8->Y8 BICUBLIN downscale
>               * YV12->YV12 BUCUBIC downscale
>               * YV12->YV12 BUCUBIC upscale
>         
>         Algorithms:
>               * all algorithms, YV12->YV12 downscale and upscale
>         
>         Special converters;
>               * YV12->YUY2
>               * YV12->BGR24
>               * BGR24->BGR32
>               * BGR24->YV12
>         
> These particular tests I only ran on gcc 4.0.2 (-fPIC and -fno-PIC) but
> combined with the other tests I ran with the other compilers, I think
> there's a strong assurance that this patch doesn't break anything.

Michael, OK to apply?

Diego