[MPlayer-dev-eng] MKV files and subtitles charset

[Evgeniy Stepanov]

On Saturday 05 August 2006 18:19, Evgeniy Stepanov wrote:
> Recoding is performed by subcp_recode1() call at the end of
> handle_subtitles(), and it is definitely wrong. Subtitles in matroska are
> already in utf-8, subcp should be ignored.
>
> Further still, subcp_recode1() assumes that sub->text[i] size is
> ICBUFFSIZE=512, but mkv demuxer allocates 256 bytes only
> (demux_mkv.c:2406).
>
> I suggest removing subcp_recode1() call.
>
> There is also a minor bug in handle_subtitles(), read beyond the end of
> allocated area. Fixed by mkv_fix.patch.

So, what should be done with this patch ?
Moritz, your opinion ?