[MPlayer-dev-eng] [PATCH] config.h from MPlayer clashes with config.h from x264

[Vladislav Naumov]

> Patch applied, this will now get more widespread testing.  The rest of
> the changes are coming up soon.

config.h clashes with config.h from x264 when path to x264 includes is
passed via --with-extraincdir configure option.

This produces very confusing error messages (like multiple fseeko/ftello
in stdio.h).

Root of the problem is most source files just #include "config.h",
and hope that Makefile has a right order of directories in CFLAGS.
This is not the case with $(OPTFLAGS) - they add x264 dirs to the head
of the list of directories, before '-I..' (where correct config.h
resides).

Patch I've attached puts $(OPTFLAGS) after '-I..'.

There are two more ways to do it:
1) use #include "../config.h" and hope noone will ever put "config.h"
   outside any library source.
2) change name "config.h" to something less generic (like
   mplayer_config.h)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: config_h_clash.diff
Type: text/x-patch
Size: 4775 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060814/6f6e41ab/attachment.bin>