[MPlayer-dev-eng] [PATCH] make -format to work with -ao pcm:nowaveheader

[Guillaume POIRIER]

Hi,

On 8/9/06, Giacomo Comes <comes at naic.edu> wrote:
> Currently if you use the option -ao pcm, the only format that can be selected for
> the saved pcm stream is u8 and s16le (default).
> Tha attached patch make possible to extend the use of the option -format if you
> use the option -ao pcm:nowaveheader
> I'm not sure but it seems that the wav header do not provide a field to specify
> the endianess of the pcm samples, so it is pointless to allow -format to work
> with -ao pcm:waveheader (am I right?).
>
> With the patch applied you can select for the raw pcm file: le/be, 16/24/32 bit
> (this is what I have tested and seems to work).
>
> Apart for making -format to work with -ao pcm:nowaveheader, the only other
> difference between the patched and unpatched mplayer is that if you use the option
> -ao pcm:nowaveheader, without the patch the defaul format is s16le and with the
> patch it is s16be.
> For this reason I output also the following info string:
> [AO PCM] Info: Use -format to set the format of RAW PCM files (default: s16be)
>
> Please apply if nobody complains.

Looks like nobody complained....

Should it be applied?

Guillaume
-- 
A thing is not necessarily true because a man dies for it.
-- Oscar Wilde