[MPlayer-dev-eng] [PATCH] Fix libass with gcc 2.95

[Diego Biurrun]

On Sun, Aug 13, 2006 at 04:39:46PM +1000, Imran Syed wrote:
> 
> On 8/13/06, Uoti Urpala <uoti.urpala at pp1.inet.fi> wrote:
> >
> >On Sat, 2006-08-12 at 14:19 -0400, Jason Tackaberry wrote:
> >> When testing my -fPIC patch with gcc 2.95 I ran into some compile errors
> >> with libass.  See the attached patch.
> >
> >Again code which doesn't compile with gcc 2.95 for 5 weeks - and after 5
> >weeks only noticed by a patch submitter asked to waste time testing 2.95
> >compatibility. How long is the idiocy of requiring 2.95 support going to
> >continue?
> 
> Uh, that patch only makes changes to make it c89 (or 90 if you wish)
> compatible (the original code used some c99 decls)
> 
> Why not just add -std=c89 or -ansi to the compile flags to catch these
> things on commit (or even before commit) ? From what I see in the manpage,
> gnu89 is the default standard used which 'includes some c99 features'.

Or add -Wdeclaration-after-statement to CFLAGS like FFmpeg does.

Diego