[MPlayer-dev-eng] [PATCH] Bug with SWS_FAST_BILINEAR and runtime CPU detection in libswscale

Jason Tackaberry tack at urandom.ca
Sat Aug 12 17:23:31 CEST 2006


On Sat, 2006-08-12 at 18:13 +0300, Uoti Urpala wrote:
> I think this could be fixed by using #ifdef COMPILE_MMX2 instead of
> #ifdef HAVE_MMX2 without reverting the whole r19339.

I thought of this too but figured it was better to stay consistent with
the HAVE_* defines.

> However when I checked that I noticed there are other uses of HAVE_MMX2
> after the #undef lines for swscale_template, added in revision 3153. Did
> I miss something obvious or has this been broken for almost 5 years (not
> using all the optimized routines)?

I had noticed these segfaults last year when I was working on this port
to xine.  I figured at the time that it was something I was doing wrong,
but I have a feeling that yes, it's been broken for a long time.

Jason.




More information about the MPlayer-dev-eng mailing list