[MPlayer-dev-eng] [PATCH] macosx audio truncation

[Chris Roccati]

The current version of ao_macosx ignores immed parameter of the uninit 
() function. This causes a truncation of the audio output at the end  
of the stream. This issue, coupled with the excessive amount of  
buffering in the module causes short samples like http:// 
dev.gentoo.org/~exg/distfiles/nug.wav to not to be played at all, and  
samples with low bitrates, like http://www1.mplayerhq.hu/MPlayer/ 
samples/A-codecs/8khz-16bit-mono.wav to be severely truncated.

Thanks to Emanuele Giaquinta, who reported the issue and provided the  
test cases and the code review and testing of the patch.

The following patch addresses both issues: the buffering is limited  
to one second worth of audio, and the uninit() function is modified  
to wait for the buffer to be played before stopping the playback  
(obviously only if the immed parameter is false). The patch also  
contains a slight change in the audio pause if buffer is empty logic,  
which prevents a "bouncing" effect at the beginning of playback,  
expecially evident with low bit rate audio samples.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: macosx_audio_buffering.patch
Type: application/octet-stream
Size: 2900 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060812/ec13249a/attachment.obj>