[MPlayer-dev-eng] Too big buffer in "libmpcodecs/ad_pcm.c"?

Uoti Urpala uoti.urpala at pp1.inet.fi
Wed Aug 9 18:37:57 CEST 2006


On Wed, 2006-08-09 at 18:26 +0200, Reimar Döffinger wrote:
> Right, I misread the code in mplayer.c, this seems more like the way it
> was intended.
> How does the attached (untested) patch look to you?

I'd either 
- just return an error if the minimum size exceeds maxlen (ridiculous
  number of channels), or
- increase audio_out_minsize based on the number of channels in preinit
  (if you do that then no maxlen checks are needed in decode_audio).




More information about the MPlayer-dev-eng mailing list