[MPlayer-dev-eng] [PATCH] don't quit playing audio if video stream ends

Uoti Urpala uoti.urpala at pp1.inet.fi
Sat Aug 5 18:16:12 CEST 2006


On Sat, 2006-08-05 at 16:42 +0200, Nico Sabbi wrote:
> for the future I have in mind to make the video stream re-initializable
> and interchangable as the audio streams are now;

Is there a need to re-initialize the video stream in this case? Are
there any demuxers which break when you fall off the end of the file so
that you can't seek back later? If there are any I'd expect them to
break audio too, so seeking back would not work with your current
implementation either.

> in the meantime the attached patch should be a good temporary
> solution (in particular, wrt the present code it's still an improvement
> and it doesn't break anything).
> 
> What do you think?

I don't immediately notice anything wrong with it, but I'd prefer a
version that would leave the video open (even if OSD was nonfunctional)
and I think it wouldn't be significantly harder to implement.
- change the exit logic so it doesn't trigger unless both streams are
  over (new variables indicating whether streams are at end, set where
  EOF is detected now, reset on seek?)
- use the audio sleeping logic if the video stream is at end to avoid
  busyloop
Would it require anything more?




More information about the MPlayer-dev-eng mailing list